-
-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "FOSS Alternatives" #3256
base: main
Are you sure you want to change the base?
Add "FOSS Alternatives" #3256
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@sindresorhus I spent some minutes reading the guidelines with attention, if something was not followed is because I didn't understood. Can you say what parts aren't followed? |
I also know that the repository must have more than 1 month of life, thus I will left this PR open until the date. |
谢谢,您的邮件我已经收到,看到邮件后,我会第一时间回复您!
祝一切顺利!
|
Rule 1 of the guidelines: Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it So it doesnt seem like you actually read it. When reading, also follow the links the guidelines contain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things are missing and/or aren't (yet) following the guideline. Generally, in the other PRs I see how people go through the checklist and check every item they think they fulfill. It really helps to clear the mind and actually follow the guidelines. I recommend you to do the same. Read each entry, and after you fulfill it mark it as fixed.
Anyway, here are the current issues with the list.
- You either didn't review other PRs or didn't list them in the comments as requested by the guideline.
- The PR's title should not contain quotes. Just
Add FOSS Alternatives
should be enough. - Your list doesn't yet exist for 30 days. Sorry but this is in the guideline. You'll have to wait and probably re-create the PR.
- I don't think you've ran the awesome-lint on your list, yet. Its formatting doesn't follow the standard approved by the linter. While I would agree that it would make sense to change the formatting to "proprietary alternative | foss alternative" table format, you still have to pass the linter, perhaps by adding a bunch of exclusions from certain rules. Read the linter documentation.
- Your Contents section is not formatted correctly: it should be named exactly Contents and not Index. Also, it should go first in the list.
- No contribution guidelines in the repo.
- Sections like Approval Criteria and Template from your list are probably better served as part of the
CONTRIBUTING.md
and not theREADME.md
itself.
Once again, pretty please read every line of the guideline and thoroughly check if your list follows them.
Good luck with your list, it looks really useful!
@@ -892,6 +892,7 @@ | |||
- [HPC](https://github.com/dstdev/awesome-hpc#readme) - High Performance Computing. | |||
- [Geocaching](https://github.com/FoxFil/awesome-geocaching#readme) - Outdoor treasure-hunting activity that uses GPS-enabled devices. | |||
- [Regex](https://github.com/slevithan/awesome-regex#readme) - Specialized language for matching patterns in text. | |||
- [FOSS Alternatives](https://github.com/hardBSDk/awesome-alternatives#README) - A list of free and open-source alternatives for proprietary, freeware and shareware programs, games, web services and operating systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd sauggest making the description more succint. Also, #README
should be replaced with #readme
, otherwise it doesn't really work.
- [FOSS Alternatives](https://github.com/hardBSDk/awesome-alternatives#README) - A list of free and open-source alternatives for proprietary, freeware and shareware programs, games, web services and operating systems. | |
- [FOSS Alternatives](https://github.com/hardBSDk/awesome-alternatives#readme) - Free and open-source alternatives for proprietary software. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your list does not link back to the awesome list with the badge. See guidelines:
Includes the Awesome badge.
[Insert URL to the list here]
https://github.com/hardBSDk/awesome-alternatives
[Explain what this list is about and why it should be included here]
This list is a catalog of free and open-source alternatives for proprietary, freeware and shareware programs, games, web services and operating systems.
It aims to help people to migrate from non-free programs or discover better programs and games.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.